Fix query projections with numeric arrays #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, this works, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case described in #144 (comment). This PR hardens the detection for numeric arrays and uses the same detection used in the legacy driver (requires sequential indexes starting with 0).
Additionally, this PR throws a
MongoExceptionwhen a legacy projection is used and one of the fields given is not a string (e.g.['field', true]).@palmic I've tested the new version against the tests you wrote and everything works as expected. If you want to give your test suite a spin before I merge this, let me know. You can do this by replacing the requirement for the adapter in
composer.jsonwith"alcaeus/mongo-php-adapter": "dev-projection-with-numeric-keys". There shouldn't be any issues, but since I changed the detection of numeric arrays and you're apparently using hashes with numeric keys, there might be some edge cases you run into.