Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing to see here; testing doc build #195

Closed
wants to merge 2 commits into from
Closed

Nothing to see here; testing doc build #195

wants to merge 2 commits into from

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented May 27, 2022

Testing that we get doc build checks.

@dotsdl
Copy link
Member Author

dotsdl commented May 27, 2022

We are watching for the readthedocs check, but don't see it yet. Will try again with this once we get a response on this request.

@dotsdl
Copy link
Member Author

dotsdl commented May 27, 2022

We think org-level OAuth permissions are what we need to fix #156.

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #195 (6fad4ca) into master (0d701d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          24       24           
  Lines        1340     1340           
  Branches      290      290           
=======================================
  Hits         1316     1316           
  Misses          5        5           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d701d1...6fad4ca. Read the comment docs.

@dotsdl
Copy link
Member Author

dotsdl commented May 27, 2022

See also: readthedocs/readthedocs.org#8033

@dotsdl
Copy link
Member Author

dotsdl commented May 27, 2022

@mikemhenry in RTD I had to go to > Settings > Connected Services and Disconnect, then reconnect my Github account. I was then able to authorize RTD as a third party application for the alchemistry Github org, now that I'm an Onwer. I put in a request to do the same on OpenFreeEnergy's org. You should see that in the Third-party access tab under that org's settings if you want that enabled there.

@dotsdl
Copy link
Member Author

dotsdl commented May 27, 2022

So this looks like it may be working now. 😁

@dotsdl
Copy link
Member Author

dotsdl commented May 27, 2022

We now have a check in PRs for readthedocs builds, which features a link to the doc build under Details. For example: https://alchemlyb--195.org.readthedocs.build/en/195/

@dotsdl
Copy link
Member Author

dotsdl commented May 27, 2022

We should see those builds populate for new and existing PRs. Closing this test PR out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant