Remove the 'dhdl' method in decorrelating the u_nk #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
- Coverage 98.56% 98.56% -0.01%
==========================================
Files 25 25
Lines 1677 1673 -4
Branches 345 343 -2
==========================================
- Hits 1653 1649 -4
Misses 3 3
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
orbeckst
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'dhdl' method in
u_nk2serieswill just take the column that is the same as the current lambda, which sometimes will give you a list of zero and makes no sense at all. This PR will remove this method and change the defaultdE.This PR also rename the 'dhdl_all' to 'all' as the name 'dhdl_all' does not make sense when working on
u_nk2series.