Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13 add support for monolog/monolog:^2.0, symfony/console:^4.2, and s… #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrglasgow
Copy link

…ymfony/process:^4.2, and switched to phpexiftool/exiftool:^10.10 instead of exiftool/exiftool:^11

…4.2, and symfony/process:^4.2, and switched to phpexiftool/exiftool:^10.10 instead of exiftool/exiftool:^11
@Eboubaker
Copy link

thanks i was going to fork this and try to figure this out myself, seems maintainer doesn't care anymore

@ghost
Copy link

ghost commented May 11, 2023

Could we get this released? @4rthem @jygaulier Currently the package can be installed for Symfony 2 or 3, but not for 4.

@jygaulier
Copy link
Member

Hi @jrglasgow @Eboubaker @arnaubuch .
We have recently moved to default branch 4.x which allows sf4, php8, bumps exiftool, ...
The "master" branch is outdated but still here for bc with old devs. We released 4.x for our own purpose, but - depending how you use it - , you may have no bc breaks compared to master.
This lib is to be considered quite obsolete, and you are right : We don't really have time to maintain the way it should be (with detailed changelog, better code testing coverage, updated documentation... and time to read pr(s) ).

@Eboubaker
Copy link

Then could you please add a note to the readme with big text that this branch is no longer maintained!

@ghost
Copy link

ghost commented May 12, 2023

Hi @jygaulier, branch 4.x does not allow Symfony 4 installs, only above 5.4. There is a very strange 4.1 release in Packagist that allows up to 3.4 (while the 4.0 release doesn't), and it is the one we're using for our purposes. Adding compatibility with sf4 from that 4.1 release should be pretty easy, although I haven't been able to locate the code source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants