Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alloy] Implement a generic Tower metrics service layer, use in Alloy #787

Closed
dancoombs opened this issue Sep 10, 2024 · 0 comments
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dancoombs
Copy link
Collaborator

Describe the feature
We currently have 2 Tower service layer implementations for metrics:

Incoming RPC

Internal gRPC

We need a 3rd for our new Alloy Provider to track "Internal RPC" metrics.

Instead of re-implementing this logic for a 3rd time, we should build a standard layer that takes a much simpler metrics logger trait impl that can extract method info and do metrics logging. @dancoombs can help with the initial design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants