feat(middleware): create a generic middleware to collect method metrics. #804
Conversation
andysim3d
requested review from
dancoombs,
dphilipson,
0xfourzerofour and
alex-miao
as code owners
andysim3d
force-pushed
the
andy/metric-middle-ware
branch
from
0480067
to
868327d
Compare
yup I will do that in other pr. git won't allow me to split commits into multiple prs. |
What do you mean? You should be able to add it to this PR? |
I can - but prefer small prs. |
andysim3d
force-pushed
the
andy/metric-middle-ware
branch
from
36b3579
to
a28eb59
Compare
| } | ||
| _ => { | ||
| // can't extract method name for batch. | ||
| "unknown".to_string() |
| use jsonrpsee::types::Request; | ||
| use rundler_types::task::traits::RequestExtractor; | ||
|
|
||
| #[derive(Copy)] |
There was a problem hiding this comment.
You likely need to derive Clone here as well
| } | ||
| } | ||
|
|
||
| impl<S, T, Request> Service<Request> for MetricsMiddleware<S, T, Request> |
There was a problem hiding this comment.
A feature that I'm realizing now that this is missing is related to response codes. Our existing ethers based metrics layer would extract those:
Lets do this in a follow up, but we may need to also add a ResponseExtractor that can get the code out and then have that be part of the metrics.
There was a problem hiding this comment.
Mind creating a follow up ticket and assigning it to milestone v0.4 and yourself?
|
Few last comments, but other than that LGTM! Will ✅ after the small updates. |
[Closes/Fixes] #787
Proposed Changes