Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rust version and various deps #769

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Update Rust to v1.80.0
  • Update dependencies without breaking changes

Still need to update:

  • jsonrpsee is 4 versions behind. The migration looks complex, will attempt in a follow up.
  • tower - jsonrpsee has a dependency here, will do at the same time as jsonrpsee.
  • reqwest - ethers has a dependency here, will do as part of the alloy migration.

0xfourzerofour
0xfourzerofour previously approved these changes Aug 29, 2024
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from danc/remove-dev to feat/v0.4 August 29, 2024 21:09
@dancoombs dancoombs dismissed 0xfourzerofour’s stale review August 29, 2024 21:09

The base branch was changed.

@dancoombs dancoombs force-pushed the danc/update-deps branch 2 times, most recently from d8ef2ba to f219327 Compare August 29, 2024 21:22
@@ -266,7 +266,7 @@ mod test {
#[test]
fn test_out_of_bounds_display() {
let actual = get_timestamp_out_of_bounds_for_datetime().to_string();
assert_eq!(actual, "later than +262143-12-31 23:59:59.999999999 UTC");
assert_eq!(actual, "later than +262142-12-31 23:59:59.999999999 UTC");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/v0.4@ad5c323). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/builder/src/signer/aws.rs 0.00% 7 Missing ⚠️
bin/rundler/src/cli/metrics.rs 0.00% 3 Missing ⚠️
crates/builder/src/server/remote/server.rs 0.00% 1 Missing ⚠️
crates/pool/src/server/remote/server.rs 0.00% 1 Missing ⚠️
crates/sim/src/simulation/v0_6/tracer.rs 0.00% 1 Missing ⚠️
crates/sim/src/simulation/v0_7/tracer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/types/src/timestamp.rs 98.10% <100.00%> (ø)
crates/builder/src/server/remote/server.rs 0.00% <0.00%> (ø)
crates/pool/src/server/remote/server.rs 0.00% <0.00%> (ø)
crates/sim/src/simulation/v0_6/tracer.rs 0.00% <0.00%> (ø)
crates/sim/src/simulation/v0_7/tracer.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/metrics.rs 0.00% <0.00%> (ø)
crates/builder/src/signer/aws.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 59.41% <6.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (?)
builder 61.03% <0.00%> (?)
dev ∅ <0.00%> (?)
pool 65.46% <0.00%> (?)
provider 18.09% <0.00%> (?)
rpc 26.00% <0.00%> (?)
sim 78.67% <0.00%> (?)
tasks ∅ <0.00%> (?)
types 66.68% <0.00%> (?)
utils 18.28% <0.00%> (?)

@dancoombs dancoombs force-pushed the danc/update-deps branch 3 times, most recently from e1e824d to f7b4715 Compare August 29, 2024 21:58
@dancoombs dancoombs merged commit 27aa6bd into feat/v0.4 Aug 29, 2024
7 of 8 checks passed
@dancoombs dancoombs deleted the danc/update-deps branch August 29, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants