Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(estimation): increase max gas for simulation #771

Closed
wants to merge 1 commit into from

Conversation

0xfourzerofour
Copy link
Collaborator

Proposed Changes

  • Increase the max gas for simulateHandleOps to the alchemy level max as no gas. If the value is too low on some networks we will be unable to estimate properly

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.56%. Comparing base (f94f258) to head (6de66c0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
bin/rundler/src/cli/mod.rs 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
unit-tests 57.56% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 60.59% <ø> (ø)
dev 0.00% <ø> (ø)
pool 64.46% <ø> (ø)
provider 16.10% <ø> (ø)
rpc 25.63% <ø> (ø)
sim 78.53% <ø> (+0.04%) ⬆️
tasks ∅ <ø> (∅)
types 66.68% <ø> (ø)
utils 18.28% <ø> (ø)

Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets leave this as is and just modify the settings in our deployments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants