-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add bucket to histogram metrics #772
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f40451d
to
d29ea20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you'll need to fix the commit messages and I can give another check.
f7401c2
to
f6065b7
Compare
commits squashed. |
[Closes/Fixes] #
rundler's histgram metrics are incomplete, they miss the bucket metrics. We can only get quantile info without weights. this pr is to add buckets info. the bucket is defined as 2^x, balancing metric density and data accuracy.
Proposed Changes