Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bucket to histogram metrics #772

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: add bucket to histogram metrics #772

merged 1 commit into from
Sep 3, 2024

Conversation

andysim3d
Copy link
Collaborator

@andysim3d andysim3d commented Aug 29, 2024

[Closes/Fixes] #

rundler's histgram metrics are incomplete, they miss the bucket metrics. We can only get quantile info without weights. this pr is to add buckets info. the bucket is defined as 2^x, balancing metric density and data accuracy.

Proposed Changes

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.55%. Comparing base (376d552) to head (f6065b7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/rundler/src/cli/mod.rs 0.00% 3 Missing ⚠️
bin/rundler/src/cli/metrics.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
bin/rundler/src/cli/metrics.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/mod.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 57.55% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 60.59% <ø> (ø)
dev 0.00% <ø> (ø)
pool 64.46% <ø> (ø)
provider 16.10% <ø> (ø)
rpc 25.63% <ø> (ø)
sim 78.53% <ø> (ø)
tasks ∅ <ø> (∅)
types 66.68% <ø> (ø)
utils 18.28% <ø> (ø)

Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you'll need to fix the commit messages and I can give another check.

@andysim3d
Copy link
Collaborator Author

LGTM, you'll need to fix the commit messages and I can give another check.

commits squashed.

@andysim3d andysim3d merged commit c84d9ba into main Sep 3, 2024
6 of 7 checks passed
@andysim3d andysim3d deleted the andy/metric-fix branch September 3, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants