Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setting endian before creating request will create invalid request #144

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

aldas
Copy link
Owner

@aldas aldas commented Jun 14, 2023

  • fix setting endian before creating request will create invalid request
  • add ability to set delay between sending the request and receiving request (helps with serial devices)
  • add support for serial devices in examples/index.php

add ability to set delay between sending the request and receiving request (helps with serial devices)
add support for serial devices in examples/index.php
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 96.96% and project coverage change: -0.04 ⚠️

Comparison is base (09bd467) 98.72% compared to head (fb0332c) 98.69%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
- Coverage     98.72%   98.69%   -0.04%     
- Complexity      887      892       +5     
============================================
  Files            69       69              
  Lines          2277     2291      +14     
============================================
+ Hits           2248     2261      +13     
- Misses           29       30       +1     
Flag Coverage Δ
unittests 98.69% <96.96%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Network/SerialStreamCreator.php 93.75% <ø> (ø)
src/Network/BinaryStreamConnection.php 96.29% <75.00%> (-1.71%) ⬇️
src/Network/BinaryStreamConnectionBuilder.php 100.00% <100.00%> (ø)
src/Network/BinaryStreamConnectionProperties.php 100.00% <100.00%> (ø)
...Packet/ModbusFunction/MaskWriteRegisterRequest.php 100.00% <100.00%> (ø)
...acket/ModbusFunction/MaskWriteRegisterResponse.php 100.00% <100.00%> (ø)
src/Packet/ModbusFunction/ReadCoilsRequest.php 100.00% <100.00%> (ø)
...ket/ModbusFunction/ReadHoldingRegistersRequest.php 100.00% <100.00%> (ø)
...acket/ModbusFunction/ReadInputDiscretesRequest.php 100.00% <100.00%> (ø)
...acket/ModbusFunction/ReadInputRegistersRequest.php 100.00% <100.00%> (ø)
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldas aldas merged commit 8ccb744 into master Jun 14, 2023
@aldas aldas deleted the serial_fixes branch June 14, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant