Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unit ID to be in range of 0-255. #160

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Allow unit ID to be in range of 0-255. #160

merged 1 commit into from
Mar 10, 2024

Conversation

aldas
Copy link
Owner

@aldas aldas commented Mar 10, 2024

Older MODBUS specification limited unit ID (slave id) in range of 0-247). See "Modicon Modbus Protocol Reference Guide PI–MBUS–300 Rev. J" page 19. https://modbus.org/docs/PI_MBUS_300.pdf

In newer spec that limitation is removed.

Fixes #159

Older MODBUS specification limited unit ID (slave id) in range of 0-247). See "Modicon Modbus Protocol Reference Guide PI–MBUS–300 Rev. J" page 19. But newer spec has that limitation removed.
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (6704b45) to head (d4a7345).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #160   +/-   ##
=========================================
  Coverage     98.96%   98.96%           
  Complexity      936      936           
=========================================
  Files            73       73           
  Lines          2426     2426           
=========================================
  Hits           2401     2401           
  Misses           25       25           
Flag Coverage Δ
unittests 98.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldas aldas merged commit 4839513 into master Mar 10, 2024
5 checks passed
@aldas aldas deleted the unitid0-255 branch March 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limitation of Unit ID
1 participant