fixes #33 - ReadRegistersBuilder address splitter calculates start ad… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldas
force-pushed
the
fix/33_invalid_startaddress_calculation
branch
from
4157cab
to
009c08f
Compare
1. it calculates start address incorrectly when value is 0. 2. also fixes case when addresses overlap then quantity was calculated incorrectly
aldas
force-pushed
the
fix/33_invalid_startaddress_calculation
branch
from
009c08f
to
46e41f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
============================================
+ Coverage 87.22% 87.27% +0.04%
- Complexity 611 614 +3
============================================
Files 51 51
Lines 1472 1477 +5
============================================
+ Hits 1284 1289 +5
Misses 188 188
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
============================================
+ Coverage 87.22% 87.28% +0.05%
- Complexity 611 614 +3
============================================
Files 51 51
Lines 1472 1478 +6
============================================
+ Hits 1284 1290 +6
Misses 188 188
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33