Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fc23 implementation #48

Merged
merged 4 commits into from
Apr 5, 2020
Merged

Fc23 implementation #48

merged 4 commits into from
Apr 5, 2020

Conversation

aldas
Copy link
Owner

@aldas aldas commented Mar 27, 2020

resolves #47

  • adds FC23 function implementation
  • adds request time on example request page

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #48 into master will increase coverage by 0.85%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
+ Coverage     87.28%   88.13%   +0.85%     
- Complexity      614      661      +47     
============================================
  Files            51       53       +2     
  Lines          1478     1585     +107     
============================================
+ Hits           1290     1397     +107     
  Misses          188      188              
Impacted Files Coverage Δ Complexity Δ
...dbusFunction/ReadWriteMultipleRegistersRequest.php 100.00% <100.00%> (ø) 15.00 <15.00> (?)
...busFunction/ReadWriteMultipleRegistersResponse.php 100.00% <100.00%> (ø) 31.00 <31.00> (?)
src/Packet/ResponseFactory.php 97.22% <100.00%> (+0.16%) 15.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020737c...bb8153d. Read the comment docs.

@aldas aldas merged commit de22a07 into master Apr 5, 2020
@aldas aldas deleted the fc23_implementation branch April 5, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement function 23 on modbus
1 participant