Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage Build #81

Merged
merged 2 commits into from
Nov 5, 2023
Merged

AppImage Build #81

merged 2 commits into from
Nov 5, 2023

Conversation

qurious-pixel
Copy link
Contributor

@qurious-pixel qurious-pixel commented Nov 4, 2023

Can be used to provide portability
Issue: #86

.github/assets/Dolphin-memory-engine.desktop Outdated Show resolved Hide resolved
.github/assets/Dolphin-memory-engine.png Outdated Show resolved Hide resolved
.github/assets/appimage.sh Outdated Show resolved Hide resolved
@dreamsyntax
Copy link
Collaborator

dreamsyntax commented Nov 4, 2023

Lastly, regarding

#80

This is not actually related to #80, that is to add an extra option for User / System scope.
I created #86.

@dreamsyntax
Copy link
Collaborator

dreamsyntax commented Nov 4, 2023

FYI, pipeline failing. Let me know if you dont have access to view runs.

Run .github/assets/appimage.sh
/home/runner/work/_temp/99cef56d-a49b-4256-a0cc-d88e96d18449.sh: line 1: .github/assets/appimage.sh: Permission denied
Error: Process completed with exit code 126.

@qurious-pixel
Copy link
Contributor Author

I didn't have the exec bit set on appimage.sh, and I had pushed the fix, but guess it didn't take it. I can set it again and push all as a single commit, or individually with the requested changes.

@dreamsyntax
Copy link
Collaborator

I didn't have the exec bit set on appimage.sh, and I had pushed the fix, but guess it didn't take it. I can set it again and push all as a single commit, or individually with the requested changes.

Either is fine, though generally I prefer single commits.

@dreamsyntax
Copy link
Collaborator

dreamsyntax commented Nov 4, 2023

For future reference, you can just git rebase onto latest master to avoid combining multiple merges
git fetch --prune
git checkout master
git pull
// the above gets the latest master locally
// the below will rebase your branch on master.
git checkout your-branch
git rebase master
-> Resolve conflicts if there are any.
git push -f // you will have to force push since you are changing the history.

Now that it has a merge commit in it though, it may be hard to correct without redoing the changes or cherry-picking your specific commits. Sorry for the hassle, if you want I can just do this before merging.

@qurious-pixel
Copy link
Contributor Author

Yes please fix, I am on mobile for now. I can rebase properly when I have a chance.

@dreamsyntax
Copy link
Collaborator

Tested it, it looks like the icon does not work but everything else works.
You mentioned we should probably use ubuntu 20.04 as a builder. Does that increase compatibility with certain systems or something? If yes, I'm fine changing it.
image

@qurious-pixel
Copy link
Contributor Author

The lower libc requirement increases compatibility, but after rethinking, there are 6 months left on that LTS, it is easier to leave on the current build image (22.04).

Will look at the icon.

Copy link
Collaborator

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon still does not work, but it seems there's issues with Windows displaying the icon too. For now merging this

@dreamsyntax dreamsyntax merged commit 6cef7a7 into aldelaro5:master Nov 5, 2023
@qurious-pixel qurious-pixel deleted the app branch November 5, 2023 17:22
@dreamsyntax
Copy link
Collaborator

dreamsyntax commented Nov 5, 2023

Update, my mistake. The icon is working with the final version merged.
Was my system cache.

Thanks for all your effort! @qurious-pixel
image

@cristian64
Copy link
Collaborator

[...], there are 6 months left on that LTS, it is easier to leave on the current build image (22.04).

If we were talking about Ubuntu 20.04 LTS, official support ends in April 2025; that's 17 months from now. And then there is a period of security updates for another 5 years.

Unsure how easy it'd be to get Qt 6 on Ubuntu 20.04 in GitHub Actions, though.

@qurious-pixel
Copy link
Contributor Author

If we were talking about Ubuntu 20.04 LTS, official support ends in April 2025; that's 17 months from now. And then there is a period of security updates for another 5 years.

Unsure how easy it'd be to get Qt 6 on Ubuntu 20.04 in GitHub Actions, though.

Yes, you are right, I had miscounted 4 years, instead of 5.
On the CI, I can get support for QT6 fairly easily. It will be more difficult with the package manager, because the backports are not often updated. Ubuntu 18.04 had an issue, because the precompiled used a later libc version that was incompatible, requiring 60GBs to compile the package.
Qt6 support, libc version, and old enough compiler (something available on the latest point release of the supported system) are usually the factors to consider.

@cristian64
Copy link
Collaborator

If the official precompiled binaries from the Qt Online Installer are available for direct download (are they?), they should work with Ubuntu 20.04, which uses glibc 2.31; the precompiled binaries (GCC x64) in Qt 6.5.3 are compiled against glibc 2.28.

On the CI, I can get support for QT6 fairly easily. [...]

Are there APT-based repositories that could be used in Ubuntu 20.04? Or do you have another source in mind?

@qurious-pixel
Copy link
Contributor Author

Ubuntu 18.04 was glibc 2.27, so it was not so easy to upgrade to Qt6.

Ubuntu Focal PPA:

sudo add-apt-repository ppa:rncbc/qt6.6-static-focal
sudo apt update

The CI could use a Github Action

    - name: Install Qt
      uses: jurplel/install-qt-action@v3
      with:
        aqtversion: '==3.1.*'
        version: '6.6.0'
        host: 'linux'
        target: 'desktop'
        arch: 'gcc_64'

@cristian64
Copy link
Collaborator

I was hoping we would go as far as Ubuntu 20.04. Are you aiming for Ubuntu 18.04?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants