Add auto-hooking mechanism. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialog is now disabled/enabled according to the hook state. Its
associated menu action in the **View** top-bar menu is also synced.
Bonus: Also the following build warning has been addressed:
```
/w/Dolphin-memory-engine/Source/GUI/MemCopy/DlgCopy.cpp:62:27: warning: comparison between 'enum QDialogButtonBox::ButtonRole' and 'enum QDialogButtonBox::StandardButton' [-Wenum-compare]
62 | else if (role == QDialogButtonBox::Close)
| ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
```
dreamsyntax
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
I'm not exactly liking the removal of the single click flow for hook/unhook, but I also acknowledge for most users it's redundant.
I suppose this is fine for now, I think we should consider redesigning the general view anyway. The info about where the address is hooked to could maybe just be under an info dialog popup. Hook status should definitely still be displayed, but I suppose that's for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: