Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Support #96

Closed
wants to merge 6 commits into from
Closed

Conversation

RainbowTabitha
Copy link

No description provided.

Copy link
Collaborator

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested; Thank you very much for this PR.

Source/CMakeLists.txt Outdated Show resolved Hide resolved
Source/Resources/logo.png Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@RainbowTabitha
Copy link
Author

Okay should be all set. For whatever reason on macos it always detects the extended Wii memory but it's only a visual thing and the program still works.

@RainbowTabitha
Copy link
Author

I attached a debug dolphin binary to the readme for people who don't know how to compile a debug copy of dolphin on macos.

@RainbowTabitha
Copy link
Author

Codesigning should not be nessary for this app to work so tell me if u have an issue, I just wonder if my global certificate may be spoofing that so I would like some other Mac user to test it first

@campital
Copy link
Contributor

If I recall correctly, the macOS port (#50) required a removal of the cache mechanism for performance reasons. Not sure whether this is true for the newer versions, but I can test this soon. Also, @dreamsyntax I'm just seeing your comments from a few months ago on my PR. I can rebase it within the next few days or we can go with this PR.

@dreamsyntax
Copy link
Collaborator

If I recall correctly, the macOS port (#50) required a removal of the cache mechanism for performance reasons. Not sure whether this is true for the newer versions, but I can test this soon. Also, @dreamsyntax I'm just seeing your comments from a few months ago on my PR. I can rebase it within the next few days or we can go with this PR.

I would prefer to go with this as its actively being used. If we identify issues we can iterate using your PR as reference.

@RainbowTabitha
Copy link
Author

Also not sure where the code signing is coming from on the other PR as this one actively doesn't need those entitlements just dolphin itself does.

@dreamsyntax
Copy link
Collaborator

@EndangeredNayla @campital please collaborate on the resolution
Are we going to change this PR to merge into campital's PR (for the GH action) and any README adjustments?

@dreamsyntax
Copy link
Collaborator

I'm not sure if discussion was had off GH, but seeing as this is now inactive and #50 is nearing completion, closing this.
Make a new PR with README changes and anything else if you wish based on final changes in #50.

@RainbowTabitha RainbowTabitha mentioned this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants