Remove primary cache #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, DME constantly unhooked when a watch entry from Wii MEM2 was present while a GameCube game was running
dreamsyntax
requested changes
Jan 17, 2024
|
Did testing on linux, wow. It runs just as well and less memory (30mb avg vs 100mb avg) I'll just need to do some tests on Windows, then once you restore gitignore line I think we're good to merge. |
dreamsyntax
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the primary cache yields a very significant performance improvement on all platforms (90% reduction in memory usage, CPU usage is no longer 100%). The cache does not seem to serve any actual purpose. Memory viewer GUI is now much more usable on Windows, though there remains some sluggishness due to the high memory refresh rate.
Also fixed a crash bug in
DlgAddWatchEntry.cpp, an unhooking bug that occurred when MEM2 memory watches were still present while loading a game without MEM2, and a bug that prevented DME from discovering Dolphin when closed and relaunched.