Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dequantize still shows up after setting GQR0 #2

Open
magcius opened this issue Nov 25, 2019 · 4 comments
Open

dequantize still shows up after setting GQR0 #2

magcius opened this issue Nov 25, 2019 · 4 comments

Comments

@magcius
Copy link

magcius commented Nov 25, 2019

image

@aldelaro5
Copy link
Owner

Just to inform: I will check this once I come back to be active on gc/wii reversing which I plan for Q1 2020.

@aboood40091
Copy link

Any update on this? For me, it results in many checks for variables that already have a fixed value at the top of the function and many "if (true)" and "if (false)" that make the code very bloated and ugly.

Example:
unknown (4)

All the code in red is useless.

@magcius
Copy link
Author

magcius commented Jun 19, 2021 via email

@aboood40091
Copy link

Thanks! It's much cleaner than before. I do still end up with few "if (false)" and "if (true)" but I guess I could live with them.
image
image

I guess they exist because of the W in psq_l frD, d(rA), W, I, but I'm curious why it can't optimize that away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants