Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Falling Words" game #11

Merged
merged 4 commits into from
Oct 4, 2021
Merged

Added "Falling Words" game #11

merged 4 commits into from
Oct 4, 2021

Conversation

Specy
Copy link
Contributor

@Specy Specy commented Oct 3, 2021

I added my game, if it's approved i can work on it

@vercel
Copy link

vercel bot commented Oct 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/aldy-san/zeroneko/5bA28pdC6pg96QaY5vfGKzrTaYy3
✅ Preview: https://zeroneko-git-fork-specy-master-aldy-san.vercel.app

@Specy Specy changed the title Added game idea Added "Falling Words" game Oct 3, 2021
@Specy
Copy link
Contributor Author

Specy commented Oct 3, 2021

Ok i finished the new game mentioned in #5
Edit: i'm not sure why Vercel says that the build failed, i can't seem to be able to access the logs, but locally it builds fine

@aldy-san
Copy link
Owner

aldy-san commented Oct 3, 2021

i've done review your code and check the log. this error is caused by some unused variable and missing react-hook. i put the log below.

image

Edit: I've tried the game you make, i want to ask how to enter the input? (i try using "space"), idk why my answer is wrong.

image

@aldy-san aldy-san added enhancement New feature or request hacktoberfest Issue for hacktoberfest labels Oct 3, 2021
@Specy
Copy link
Contributor Author

Specy commented Oct 4, 2021

It checks if the text falling is the same as the text you added, so what you write should be using the Japanese alphabet. I thought that users could learn how to learn the Japanese keyboard.

If you prefer I can put both the romanised and actual Japanese

@aldy-san
Copy link
Owner

aldy-san commented Oct 4, 2021

thank you for adding romanised alphabet, but it still error cause react-hook missing dependency "loadGame". here the log below.

image

@Specy
Copy link
Contributor Author

Specy commented Oct 4, 2021

Also, the game restarts whenever you change the window width/height, this makes the content more responsive but causes an issue when opening the keyboard on android, should i remove it?

@aldy-san aldy-san merged commit e8f9af1 into aldy-san:master Oct 4, 2021
@aldy-san
Copy link
Owner

aldy-san commented Oct 4, 2021

i think its good for now, i will merge your PR, thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Issue for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants