Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PEP 757 C-API to import/export ints #495

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Jul 15, 2024

Closes #467

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.62%. Comparing base (224745b) to head (d55ed44).
Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
src/pythoncapi_compat.h 83.01% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
+ Coverage   85.52%   85.62%   +0.09%     
==========================================
  Files          50       50              
  Lines       11656    11755      +99     
  Branches     2202     2222      +20     
==========================================
+ Hits         9969    10065      +96     
- Misses       1687     1690       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skirpichev
Copy link
Contributor Author

@casevh, at this point I would appreciate your feedback on capi-workgroup/decisions#35. Proposed API has noticeable speed regression for int->mpz conversion. I'm not sure if this is acceptable for gmpy2.

@skirpichev skirpichev force-pushed the trying-py-import-export branch from 3612d2f to c9c32c6 Compare December 13, 2024 14:57
@skirpichev skirpichev changed the title Use PyLong_Import/Export API Use PEP 757 C-API to import/export ints Dec 13, 2024
@skirpichev skirpichev marked this pull request as ready for review December 13, 2024 14:59
@skirpichev
Copy link
Contributor Author

@casevh, this is ready for review

@casevh casevh merged commit bf07280 into aleaxit:master Dec 22, 2024
11 checks passed
@casevh
Copy link
Collaborator

casevh commented Dec 22, 2024

Thanks for all the work on this.

@skirpichev skirpichev deleted the trying-py-import-export branch December 22, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternatives to using private API for conversion to/from CPython int's
3 participants