Skip to content

Commit

Permalink
fix(client): remove unnecessary wl_output_roundtrip
Browse files Browse the repository at this point in the history
At this point we're not awaiting any protocol events and flushing
wayland queue makes little sense. As Alexays#1019 shows, it may be even harmful
as an extra roundtrip could process wl_output disappearance and delete
output object right from under our code.
  • Loading branch information
alebastr committed Feb 9, 2021
1 parent f3ce7ff commit 6585381
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/client.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ void waybar::Client::handleOutputDone(void *data, struct zxdg_output_v1 * /*xdg_

auto configs = client->getOutputConfigs(output);
if (!configs.empty()) {
wl_display_roundtrip(client->wl_display);
for (const auto &config : configs) {
client->bars.emplace_back(std::make_unique<Bar>(&output, config));
}
Expand Down

0 comments on commit 6585381

Please sign in to comment.