WIP: Update for GNOME 45 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR is working for me. Most window titlebars for my gnome apps have some sort of input button (like new tab button on terminal app). For these windows, this extension does not hide the titlebar upon maximize. And I think that is actually "correct" behavior since those inputs might be necessary to interact with app. The only window titlebar I could find without such input buttons was the OSS
|
|
Wow, you're right, @mikehenrty ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has my attempt to address these review comments.
Unfortunately, it does not currently work. I'm placing it here until I have more time to debug in case anyone with more knowledge can figure out what is going wrong.