Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text not readable with "rrt" style #212

Closed
mewmew opened this issue Jan 2, 2019 · 3 comments
Closed

Text not readable with "rrt" style #212

mewmew opened this issue Jan 2, 2019 · 3 comments

Comments

@mewmew
Copy link

mewmew commented Jan 2, 2019

Hi Alec,

I've had great fun these last few days taking Chroma out for a spin!

Wrote a quick script that allows you to select the Chroma style to use. All works fine, except one it seems. The text of rrt style is not readable, as it uses black foreground text on black background.

PoC:

https://mewspring.github.io/poc/chroma/rrt/main_c_0001.html

2019-01-02-212727_1081x486_scrot

2019-01-02-212747_1011x478_scrot

Cheers,
Robin

mewmew added a commit to mewmew/explore that referenced this issue Jan 2, 2019
@Jos512
Copy link
Contributor

Jos512 commented Jan 16, 2019

I see the problem, thanks for reporting it.

The issue happens because Chroma's rtt.go style doesn't recognise everything. If I look at the Pygments source (which Chroma is based on), then Pygments neither highlights that much. Here's a webpage with the output that Pygments makes, and there the rtt style also lacks highlight for various code elements.

With a bit of digging I did find here what Pygments uses for rtt. That source is, however, five years old. If it would be more recent, I'd use that source and make a pull request for this issue. But now I'm not sure what the best approach is.

Any thoughts? If that older source is okay, I'd happily send in a pull request.

@mewmew
Copy link
Author

mewmew commented Jan 16, 2019

@Jos512, thanks for diving into this problem!

Any thoughts? If that older source is okay, I'd happily send in a pull request.

I think @alecthomas would have to decide on the approach best suited.

@alecthomas
Copy link
Owner

I think it just needs a default text colour set in the theme. I'd definitely appreciate a PR @Jos512, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants