This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Cleanup VIPs on startup #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steven-sheehy
commented
Nov 28, 2018
•
steven-sheehy
commented
- Fixes Duplicate VIPs on multiple nodes #65 - Perform the same cleanup on startup that is currently done during shutdown to remove VIPs and flush iptables
- Avoid unnecessary apiserver calls if configmap hasn't changed
- Fixed docker build failing with libipset3 not found
Signed-off-by: Steven Sheehy <ssheehy@firescope.com>
aledbf
reviewed
Nov 28, 2018
|
@aledbf I've addressed the issue you mentioned. Is there anything else I need to address? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.