Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

Fix race condition crash on startup #75

Merged
merged 1 commit into from
Dec 22, 2018

Conversation

steven-sheehy
Copy link
Contributor

Fixes #74

  • Adds a keepalived.IsRunning() method that checks if keepalived.Start() has been called and that the main keepalived pid file exists.
  • Waits for keepalived to be running before reloading configuration. This ensures keepalived's SIGHUP handler is running before sending a SIGHUP.
  • Enhances the health check to also check if main and vrrp processes are running.

@steven-sheehy
Copy link
Contributor Author

/assign @aledbf

@steven-sheehy steven-sheehy changed the title Fix crashing race condition on startup Fix race condition crash on startup Dec 19, 2018
@coveralls
Copy link

coveralls commented Dec 19, 2018

Coverage Status

Coverage decreased (-0.3%) to 15.097% when pulling e9ffc21 on steven-sheehy:keepalived-crash-startup into 34a46af on aledbf:master.

Signed-off-by: Steven Sheehy <ssheehy@firescope.com>
@steven-sheehy steven-sheehy force-pushed the keepalived-crash-startup branch from c4b3fb6 to e9ffc21 Compare December 19, 2018 19:57
@aledbf
Copy link
Owner

aledbf commented Dec 22, 2018

@steven-sheehy thanks!

@aledbf aledbf merged commit 89bb4c9 into aledbf:master Dec 22, 2018
@steven-sheehy
Copy link
Contributor Author

Any chance of a release soon?

@aledbf
Copy link
Owner

aledbf commented Dec 22, 2018

@steven-sheehy done

@steven-sheehy steven-sheehy deleted the keepalived-crash-startup branch May 7, 2019 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants