Re-Enable drop out of Preview mode when adding a bookmark, while reta… #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ining the Editor Column setting (issue 74).
|
Hi @muellerkyle , First of all, sorry for taking so long to answer you. I've been busy with other projects and couldn't return to this extension. About the PR, I must be honest, I didn't note the behavior has changed. It was probably a VSCode API Change which inverted the values. That's really weird. Sure I can re-enable. I will merge your PR and release an update soon 👍 Stay tuned |
|
Alessandro,
Thank you! Much appreciated!
…On Thu, Feb 1, 2018 at 5:52 PM, Alessandro Fragnani < ***@***.***> wrote:
Merged #90 <#90>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM9ZTt8IIuDT6q8ITDUbj6X7pRiQZY1ks5tQkA9gaJpZM4ReukY>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ining the Editor Column setting (issue 74).
Hi alefragnani,
Will you consider this change for inclusion in your extension?
Thank you!
Kyle Mueller