Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape dollar #22

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Escape dollar #22

merged 1 commit into from
Jul 1, 2017

Conversation

idleberg
Copy link
Contributor

The following warning appeared in the console after installing your extension:

The "region"-snippet very likely confuses snippet-variables and snippet-placeholders. See https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax for more details.

It appears the dollar sign in one of the snippets wasn't escaped, this PR fixes that.

The following warning appeared in the console after installing your extension:

> The "region"-snippet very likely confuses snippet-variables and snippet-placeholders. See https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax for more details.

It appears the dollar sign in one of the snippets wasn't escaped, this PR fixes that.
@alefragnani alefragnani merged commit 9118bbe into alefragnani:master Jul 1, 2017
@alefragnani
Copy link
Owner

Hi @idleberg ,

Thanks for the PR 👍 .

I just published an update to the extension containing your fix.

@alefragnani alefragnani added the bug label Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants