BREAKING | Simplify classes #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚀 feature
alejandrohdezma
force-pushed
the
feature/fixtures
branch
from
0b2e3fd to
5065755
Compare
alejandrohdezma
force-pushed
the
feature/fixtures
branch
from
5065755 to
d6e2f6e
Compare
github-actions
bot
added
⚖️ XL
alejandrohdezma
force-pushed
the
feature/fixtures
branch
5 times, most recently
from
f312c80 to
981527f
Compare
Use attributes to provide context for `AuthedRoutes` instead
So people don't mistake it with a tuple
…MUnitFunFixture`
alejandrohdezma
force-pushed
the
feature/fixtures
branch
from
690fa07 to
e26eab7
Compare
alejandrohdezma
force-pushed
the
feature/fixtures
branch
from
e26eab7 to
a6c5ee8
Compare
Dependency Updates
Dependency Updates
Signed-off-by: Alejandro Hernández <info@alejandrohdezma.com>
Dependency Updates
Dependency Updates
Dependency Updates
Dependency Updates
# Conflicts: # build.sbt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 How to review this PR?
This PR was created with the idea of being reviewed commit by commit. Each commit contains an incremental change that makes it easier to review. Also some of the commits contain additional information in their description to help understand why the change was made.
I also recommend checking "Hide whitespace" when reviewing this PR!
🚀 What's included in this PR?
📦 Use attributes for storing auth context on
AuthedRoutesSuiteInstead of having to parametrize everything with
ContextRequest. Although this change is in fact a breaking change, it shouldn't have much effect on most codebases, since adding the context has been implemented into theRequest#contextextend method.🔥 Simplify hierarchy
The type parameter in
Http4sSuitehas been removed, since we can just useRequesteverywhere. This also allows to directly implementhttp4sMUnitNameCreator,testandhttp4sMUnitFunFixtureat the top level.New methods have been created for providing the fixture running the tests, as well as a new class representing test-names creator.
The
Http4sMUnitTestCreatorhas been extracted to its own class.