Add in-place functions to coords-based augmentables #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleju
force-pushed
the
inplace_funcs
branch
3 times, most recently
from
5145c67 to
91a0c56
Compare
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
==========================================
+ Coverage 96.34% 96.38% +0.04%
==========================================
Files 37 37
Lines 13366 13494 +128
==========================================
+ Hits 12877 13006 +129
+ Misses 489 488 -1 |
This patch adds in-place versions of existing functions to coordinate-based augmentable classes, i.e. keypoints, BBs, LineStrings and Polygons (both single instances and *OnImage containers). The in-place functions should improve performance during augmentation by re-instantiating objects less often. Changes: + Add augmentables.utils.project_coords_() + Add setter for KeypointsOnImage.items + Add setter for BoundingBoxesOnImage.items + Add setter for LineStringsOnImage.items + Add setter for PolygonsOnImage.items + Add Keypoint.project_() + Add Keypoint.shift_() + Add KeypointsOnImage.on_() + Add KeypointsOnImage.remove_out_of_image_fraction_() + Add KeypointsOnImage.clip_out_of_image_fraction_() + Add KeypointsOnImage.shift_() + Add BoundingBox.project_() + Add BoundingBox.extend_() + Add BoundingBox.clip_out_of_image_() + Add BoundingBox.shift_() + Add BoundingBoxesOnImage.on_() + Add BoundingBoxesOnImage.clip_out_of_image_() + Add BoundingBoxesOnImage.remove_out_of_image_() + Add BoundingBoxesOnImage.remove_out_of_image_fraction_() + Add BoundingBoxesOnImage.shift_() + Add LineString.project_() + Add LineString.shift_() + Add LineStringsOnImage.on_() + Add LineStringsOnImage.remove_out_of_image_() + Add LineStringsOnImage.remove_out_of_image_fraction_() + Add LineStringsOnImage.clip_out_of_image_() + Add LineStringsOnImage.shift_() + Add Polygon.project_() + Add Polygon.shift_() + Add PolygonsOnImage.remove_out_of_image_() + Add PolygonsOnImage.remove_out_of_image_fraction_() + Add PolygonsOnImage.clip_out_of_image_() + Add PolygonsOnImage.shift_() + Add PolygonsOnImage.on_() + Add Polygon.subdivide_() + Add PolygonsOnImage.subdivide_() + Switch CBAOI augmentation to in-place calls + Switch BoundingBoxesOnImage.copy() to custom copy op + Switch KeypointsOnImage.copy() to custom copy op + Add bounding_boxes and shape args to BBSOI.copy() + Add bounding_boxes and shape args to BBSOI.deepcopy() + Add polygons and shape args to PSOI.copy() + Add polygons and shape args to PSOI.deepcopy()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds in-place versions of existing functions to coordinate-based augmentable classes,
i.e. keypoints, BBs, LineStrings and Polygons (both single instances and *OnImage containers).
The in-place functions should improve performance during augmentation by re-instantiating objects less often.
The should decrease a bit the performance problems mentioned in #426, though probably not by too much.