Fix random.seed not always seeding in-place #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `imgaug.random.seed()` not seeding the global `RNG` in-place in numpy 1.17+. The (unfixed) function instead created a new global `RNG` with the given seed. This set the seed of augmenters created *after* the `seed()` call, but not of augmenters created *before* the `seed()` call as they would continue to use the old global RNG.
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 95.95% 96.43% +0.48%
==========================================
Files 38 38
Lines 13933 13933
==========================================
+ Hits 13369 13436 +67
+ Misses 564 497 -67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
imgaug.random.seed()not seeding the globalRNGin-placein numpy 1.17+. The (unfixed) function instead created a new
global
RNGwith the given seed. This set the seed of augmenterscreated after the
seed()call, but not of augmenters createdbefore the
seed()call as they would continue to use the oldglobal RNG.
This is related to #555.