Change **old_kwargs magic to explicit parameters #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter names of class `Augmenter` were recently changed and the old names were caught by `**old_kwargs`. This was convenient, but is changed in this patch to be explicitly `random_state="deprecated", deterministic="deprecated"`. That is because the `**old_kwargs` magic has the disadvantage of not necessarily being fully understood by IDEs. These then cannot detect (and warn) about invalid parameters anymore. Without the magic parameter they can warn about these, hence it is the preferred choice here.
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 96.32% 96.33% +0.01%
==========================================
Files 41 41
Lines 14671 14668 -3
==========================================
- Hits 14131 14130 -1
+ Misses 540 538 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter names of class
Augmenterwere recently changedand the old names were caught by
**old_kwargs. This wasconvenient, but is changed in this patch to be explicitly
random_state="deprecated", deterministic="deprecated".That is because the
**old_kwargsmagic has the disadvantageof not necessarily being fully understood by IDEs. These then
cannot detect (and warn) about invalid parameters anymore.
Without the magic parameter they can warn about these,
hence it is the preferred choice here.