Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added delete cascade input #165

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

stevehipwell
Copy link
Contributor

This PR adds support for explicitly setting the delete cascade option to either Background or Foreground; it also changes the delete wait logic to use a watch instead of a manual poll.

Closes #156

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell
Copy link
Contributor Author

@alekc this is ready for review now.

@alekc alekc merged commit abed1de into alekc:master Aug 21, 2024
37 checks passed
@stevehipwell stevehipwell deleted the add-delete-cascade branch August 22, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Setting wait on a kubectl_manifest resource changes the delete cascade mode
2 participants