-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi platform Docker images #83
base: master
Are you sure you want to change the base?
Conversation
It was running dev mode with the Dockerfile, I changed so many things to run it on prod and its not working now :D |
Hey, let me know when this is ready to be reviewed |
Can I make major changes? For example removing compose files, changes in package-json, Dockerfile etc. I don't want it to go to waste. |
ci: trigger ci ci: gh workflow build with cache build: removed dev from Dockerfile build: removed compose files and changed docker port settings move production env to bottom move port to the bottom fix: Dockerfile command changed to node ci: do not re-download packages
Alright done. It working as expected on ARM now. Also you can specify port with PORT env now. For example; |
When are we merging this? |
I added the latest changes. |
Is this ready? I could try getting this reviewed and merged |
Yes, it is ready. |
I didn't delete the compose files because I wasn't sure of their necessity. I got the following output on ARM. I'm assuming it's working. Also its working as you wanted, running only when a release created.