Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] MixtureEditor not loading default texture editor for Texture2DArray #58

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[Fix] MixtureEditor not loading default texture editor for Texture2DArray #58

merged 1 commit into from
Nov 3, 2022

Conversation

Looooong
Copy link
Contributor

@Looooong Looooong commented Oct 31, 2022 •
edited
Loading

  • Fix infinite recursions bug when default editor is null.
  • Refactor the code in a way to prevent future error when adding custom editor for Unity built-in type.

@Looooong Looooong force-pushed the fix/mixture-editor-not-loading-default-texture-editor-for-texture2darray branch from ece42c0 to 79ab61b Compare October 31, 2022 09:30
@Looooong Looooong force-pushed the fix/mixture-editor-not-loading-default-texture-editor-for-texture2darray branch from 79ab61b to d74d3fc Compare October 31, 2022 09:35
@peeweek peeweek self-requested a review November 2, 2022 12:44
@peeweek
Copy link
Collaborator

peeweek commented Nov 2, 2022

Currently testing your branch, this stack overflow is killing me :D

peeweek
peeweek approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@peeweek peeweek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing, It fixes the problems I had with my crashes. i've tested a bit on my project @alelievr could you take a look as well for a greenlight?

Seems good for me 👍

@peeweek peeweek merged commit 8e917ef into alelievr:master Nov 3, 2022
@peeweek peeweek mentioned this pull request Nov 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peeweek peeweek peeweek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Looooong @peeweek