Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: aleph message get to handle message status #265

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Aug 30, 2024

When using aleph message get, it simply retrieves the message and does not return the status (and provides no information when it's rejected).

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Documentation

The documentation regarding the impacted features is available on:

URL

The changes in the documentation are available here:

URL

Changes

Usage of the new overload implemented in PR to get the message status, and if the status is rejected, we retrieve the message error.

How to test

Install needed sdk parts

pip install git+https://github.com/aleph-im/aleph-sdk-python.git@1yam-message-status
aleph message get item_hash

Print screen / video

image
image

Notes

This PR need PR getting merged first

Copy link

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

Copy link
Member

@philogicae philogicae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, reviewed and ready

@nesitor nesitor requested a review from hoh September 4, 2024 10:01
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 40.62%. Comparing base (34360fe) to head (c0a7b19).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/message.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   40.46%   40.62%   +0.15%     
==========================================
  Files          19       19              
  Lines        1920     1930      +10     
  Branches      331      332       +1     
==========================================
+ Hits          777      784       +7     
- Misses       1107     1109       +2     
- Partials       36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor merged commit 37fac02 into master Sep 4, 2024
18 checks passed
@nesitor nesitor deleted the 1yam-fix-get-message branch September 4, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants