Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version field to BaseMessage #84

Closed
wants to merge 1 commit into from
Closed

Conversation

MHHukiewitz
Copy link
Member

From the discussion about pay-as-you-go specs in #82 (comment):

The chain used for payment should be the same as the chain of the sender and the receiver. The chain field of the BaseMessage class is not signed however.

Then I'd just recommend changing the verification_buffer function to include the chain field (and also a new version field describing the message spec version)

@hoh
Copy link
Member

hoh commented Jun 12, 2024

It would only make sense to add a version number if and when we decide to introduce breaking changes, which is not the case so far.

@hoh hoh closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants