Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Deprecation Message #103

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Feature: Add Deprecation Message #103

merged 9 commits into from
Feb 12, 2024

Conversation

MHHukiewitz
Copy link
Member

Deprecation messages are displayed when either trying to use the now abstract classes AlephClient and AuthenticatedAlephClient in the form of either

  • ImportError when imported directly from aleph.sdk
  • or NotImplementedError when imported from their source files, with additional info about which classes to use instead.

Copy link


The PR introduces a significant change to the Python SDK library for Aleph.im network. The changes involve major modifications in setup.cfg file which may affect other parts of the system that depend on this configuration, and also updates to the __init__.py file where it raises import errors for deprecated classes (AlephClient, AuthenticatedAlephClient, synchronous, asynchronous). This PR also introduces changes in several files under the 'src/aleph/sdk' directory which may affect other parts of the system that depend on these specific modules.

The changes are categorized as BLACK because they involve extensive changes to critical components and require deep understanding of the project architecture, including its dependencies and how it interacts with other systems. Only experienced developers should review this PR, as it involves significant architectural changes. The label 'BLACK' is used sparingly in this case, indicating that this PR requires a high level of expertise and attention to detail.

Please note that the categorization may not be 100% accurate due to the complexity of the changes involved. It's always recommended to review the code changes thoroughly before merging them into the main branch.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Feb 12, 2024
@hoh hoh merged commit b6c3714 into main Feb 12, 2024
22 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-add-deprecation-message branch February 12, 2024 16:47
hoh added a commit that referenced this pull request Feb 22, 2024
Problem: too strict aleph-message dependency

Solution: loosen it to accept compatible versions to 0.4.2

Co-authored-by: Hugo Herter <git@hugoherter.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants