Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings, remove BASE until superfluid upgrade #157

Closed
wants to merge 1 commit into from

Conversation

philogicae
Copy link
Member

  • Fix annoying warnings by defining eth-utils==4.1.1
  • Disable BASE chain until superfluid.py repo is updated

@philogicae philogicae requested a review from 1yam August 27, 2024 11:00
Copy link

This PR introduces a minor update by adding a new dependency and setting a default value for a configuration parameter. These changes are straightforward and do not alter the core functionality of the library. The addition of eth-utils==4.1.1 is a typical practice to ensure compatibility with other libraries and does not pose a significant risk of introducing bugs. The change to the configuration file setting active to False is a straightforward update that does not affect the overall architecture.

Relevant part of the diff:

+    "eth-utils==4.1.1",
+    "eth-utils==4.1.1",
+    "active=False,

These changes are unlikely to introduce bugs and are focused on improving the configuration defaults without altering the core functionalities of the library. Therefore, this PR can be categorized as 'BLUE'.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Aug 27, 2024
@Psycojoker
Copy link
Collaborator

What is the warning?

@philogicae
Copy link
Member Author

What is the warning?

/home/philogicae/.pyenv/versions/3.11.8/lib/python3.11/site-packages/eth_utils/network.py:44: UserWarning: Network 345 with name 'Yooldo Verse Mainnet' does not have a valid ChainId. eth-typing should be updated with the latest networks.
  warnings.warn(
/home/philogicae/.pyenv/versions/3.11.8/lib/python3.11/site-packages/eth_utils/network.py:44: UserWarning: Network 12611 with name 'Astar zkEVM' does not have a valid ChainId. eth-typing should be updated with the latest networks.
  warnings.warn(

It appears since we added web3py to the SDK (was needed).
It's very ugly when using the CLI, since it shows up at the beginning of every command.
Now I have a dep conflict with ledgereth, which is an old package to support Ledger keys, currently trying to find a better/newer solution.

@philogicae
Copy link
Member Author

Fine after all

@philogicae philogicae closed this Aug 27, 2024
@philogicae philogicae deleted the fix-warnings-and-base branch August 27, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants