Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right type on create_session #159

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix right type on create_session #159

merged 1 commit into from
Aug 28, 2024

Conversation

philogicae
Copy link
Member

Fix for types and tests

Copy link

"summary": "The PR involves a significant change to the method signature and the way parameters are passed to the create_session method. This could potentially affect the behavior of the system and may introduce bugs if not handled correctly. The renaming of variables and the addition of new parameters indicate a more complex change that requires a deeper understanding of the codebase and its interactions.",
"highlight": [
{
"line": "certificate_prefix",
"comment": "New parameter introduced to replace vm_id."
},
{
"line": "platform_certificate_path",
"comment": "New parameter introduced to replace certificate_path."
},
{
"line": "await vm_client.create_session(certificate_prefix, platform_certificate_path, policy)",
"comment": "Call to the create_session method now requires three parameters instead of two."
}
]
}

@github-actions github-actions bot added the RED This PR is complex and may require more time to review. label Aug 28, 2024
@Psycojoker Psycojoker merged commit 0a48732 into main Aug 28, 2024
14 checks passed
@Psycojoker Psycojoker deleted the fix-create-session branch August 28, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RED This PR is complex and may require more time to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants