Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Account Handler #175

Merged
merged 12 commits into from
Oct 2, 2024
Merged

Feature: Account Handler #175

merged 12 commits into from
Oct 2, 2024

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Sep 30, 2024

Description:

This PR introduces a new configuration file chains_config.json and updates the _load_account function to handle Solana accounts. These changes simplify the process of importing wallets for Solana users.

Changes:

Added: Support for Solana accounts in the _load_account function.
Created: chains_config.json for chain-specific configurations.
chains_config.json Format:
Added: Helper functions to streamline wallet importation and account management

json

{
   "path": "path",
   "chain": "chain"
}

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Sep 30, 2024
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of things to change and improve, let's do a pair session to fix all these things.

src/aleph/sdk/account.py Outdated Show resolved Hide resolved
src/aleph/sdk/account.py Outdated Show resolved Hide resolved
src/aleph/sdk/account.py Outdated Show resolved Hide resolved
src/aleph/sdk/chains/common.py Outdated Show resolved Hide resolved
src/aleph/sdk/conf.py Outdated Show resolved Hide resolved
src/aleph/sdk/types.py Outdated Show resolved Hide resolved
src/aleph/sdk/conf.py Show resolved Hide resolved
src/aleph/sdk/account.py Outdated Show resolved Hide resolved
tests/unit/test_utils.py Outdated Show resolved Hide resolved
@nesitor nesitor self-requested a review October 2, 2024 09:59
@aleph-im aleph-im deleted a comment from github-actions bot Oct 2, 2024
@nesitor nesitor merged commit 2790df9 into main Oct 2, 2024
13 checks passed
@nesitor nesitor deleted the 1yam-solana-acount branch October 2, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants