Feature: VM cache did not support connecting through a Unix socket #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the user can only specify the URL of the cache or a complete aiohttp client session object. Solution: mirror what is done for the `AlephClient` class and allow a `unix_socket` parameter in the constructor of `VmCache` to build the client session correctly for the user.
hoh
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the user can only specify the URL of the cache or a complete aiohttp client session object.
Solution: mirror what is done for the
AlephClientclass and allow aunix_socketparameter in the constructor ofVmCacheto build the client session correctly for the user.