[Tests] Messages API tests #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #260. |
odesenfans
force-pushed
the
od-api-tests-messages
branch
from
6d8f018
to
44ec3d6
Compare
Added basic tests for the /api/v0/messages.json endpoint. Improved the app creation flow: we now create the app inside the `create_app` function. This is required to run several API unit tests, as pytest resets the event loop on each run.
odesenfans
force-pushed
the
od-api-tests-messages
branch
from
44ec3d6
to
4959189
Compare
hoh
approved these changes
May 10, 2022
|
|
||
| with fixtures_file.open() as f: | ||
| messages = json.load(f) | ||
|
|
There was a problem hiding this comment.
Would it make sense to validate the messages using aleph-message here ?
There was a problem hiding this comment.
Not really, I created most of the test data using aleph-client and got the rest from the API.
| ) | ||
|
|
||
| register_routes(app) | ||
|
|
There was a problem hiding this comment.
Too many empty lines to my taste, non-blocking 😉.
There was a problem hiding this comment.
How am I gonna increase my stats on Github otherwise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic tests for the /api/v0/messages.json endpoint.
Improved the app creation flow: we now create the app inside
the
create_appfunction. This is required to run severalAPI unit tests, as pytest resets the event loop on each run.