Feature: process instance messages #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: users cannot send `INSTANCE` messages because the format is not yet supported by CCNs. Solution: support them, obviously. Modified the program handler to support both programs and instances. Renamed most program-related functions to the more generic `vm` naming convention. DB-wise, the same tables are reused for instances and programs. The `vms` table (previously named `programs`) now contains entries for instances and programs. A new table is dedicated to rootfs volumes as that is an instance-only feature. The advantage of reusing the same tables is that the logic for instances and programs can be unified, for example the balance/cost views only require minor updates.
nesitor
approved these changes
May 22, 2023
odesenfans
force-pushed
the
od-instance-messages
branch
from
3702743
to
e2e432b
Compare
hoh
reviewed
May 31, 2023
setup.cfg
Outdated
| @@ -40,7 +40,7 @@ install_requires = | |||
| aiohttp==3.8.4 | |||
| aioipfs@git+https://github.com/aleph-im/aioipfs.git@d671c79b2871bb4d6c8877ba1e7f3ffbe7d20b71 | |||
| alembic==1.8.1 | |||
| aleph-message==0.3.2 | |||
| aleph-message@git+https://github.com/aleph-im/aleph-message@2983925295643634785a6a712d09e8f5c58642a2 | |||
There was a problem hiding this comment.
Do we want to publish an update of aleph-message first ?
src/aleph/db/models/messages.py
Outdated
| @@ -10,7 +10,7 @@ | |||
| ForgetContent, | |||
| PostContent, | |||
| ProgramContent, | |||
| StoreContent, | |||
| StoreContent, InstanceContent, | |||
|
|
||
|
|
||
| def delete_vm(session: DbSession, vm_hash: str) -> None: | ||
| _ = _delete_vm(session=session, where=VmBaseDb.item_hash == vm_hash) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: users cannot send
INSTANCEmessages because the format is not yet supported by CCNs.Solution: support them, obviously. Modified the program handler to support both programs and instances. Renamed most program-related functions to the more generic
vmnaming convention.DB-wise, the same tables are reused for instances and programs. The
vmstable (previously namedprograms) now contains entries for instances and programs. A new table is dedicated to rootfs volumes as that is an instance-only feature. The advantage of reusing the same tables is that the logic for instances and programs can be unified, for example the balance/cost views only require minor updates.