Allow multiple message types #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
requested changes
May 30, 2023
odesenfans
approved these changes
Aug 4, 2023
MHHukiewitz
force-pushed
the
mhh--filter-multiple-message-types
branch
from
cd17522
to
0e207f8
Compare
|
Rebased and ready @odesenfans |
…single message type, where other params accept a list of values Solution: add msgTypes field and deprecate msgType
odesenfans
force-pushed
the
mhh--filter-multiple-message-types
branch
from
0e207f8
to
48e6950
Compare
odesenfans
pushed a commit
to aleph-im/aleph-sdk-python
that referenced
this pull request
Sep 5, 2023
Client-side deprecation of `message_type`, see: aleph-im/pyaleph#444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
msgTypeis the only parameter when fetching messages, which does not take a list of items as a parameter.Solution: add
msgTypesas a parameter to the API and deprecatemsgType.