Feature: asynchronous garbage collector #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
force-pushed
the
od-async-garbage-collection
branch
from
b711c36
to
28e93e1
Compare
Problem: deleting files from the STORE message handler causes latency in the message processing pipeline when deleting large files. Solution: delete files asynchronously. We now spawn a garbage collector task every 24 hours by default that will look at the list of files and delete files without pins. This PR also introduces the concept of grace period pins: files without a tx or message pin can now be pinned for an arbitrary amount of time. This applies to files uploaded by users in unauthenticated mode and to files deleted by FORGET messages. The default is to give 24 hours of grace period for files.
odesenfans
force-pushed
the
od-async-garbage-collection
branch
from
28e93e1
to
fc39515
Compare
hoh
pushed a commit
that referenced
this pull request
Dec 8, 2023
Problem: deleting files from the STORE message handler causes latency in the message processing pipeline when deleting large files. Solution: delete files asynchronously. We now spawn a garbage collector task every 24 hours by default that will look at the list of files and delete files without pins. This PR also introduces the concept of grace period pins: files without a tx or message pin can now be pinned for an arbitrary amount of time. This applies to files uploaded by users in unauthenticated mode and to files deleted by FORGET messages. The default is to give 24 hours of grace period for files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: deleting files from the STORE message handler causes latency in the message processing pipeline when deleting large files.
Solution: delete files asynchronously. We now spawn a garbage collector task every 24 hours by default that will look at the list of files and delete files without pins.
This PR also introduces the concept of grace period pins: files without a tx or message pin can now be pinned for an arbitrary amount of time. This applies to files uploaded by users in unauthenticated mode and to files deleted by FORGET messages. The default is to give 24 hours of grace period for files.