CI: enable -Werror for pytest #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: lots of warnings are ignored. Solution: force developers to care by transforming them into errors.
Modified the storage tests to avoid a second deprecation warning when modifying the state of the app after it is started.
Fixes a deprecation warning.
Problem: the internal AsyncIPFS client must be closed to avoid triggering a warning.
Fixes a deprecation warning.
Fixes a SQLAlchemy deprecation warning.
Fixes a deprecation warning.
odesenfans
force-pushed
the
od-enable-werror
branch
from
2b73eb5
to
62a1f7e
Compare
Replace usage in chains/ethereum.py by `importlib.resources.load_text`.
ResourceWarning warnings occur in some tests, especially those related to storage that rely on the aiohttp pytest client. The reason could not be determined.
odesenfans
force-pushed
the
od-enable-werror
branch
from
e717fe4
to
0ccaf98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.