Fix: All node metrics were returned by default #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
force-pushed
the
hoh-metrics-limit-date-range
branch
from
04a4afd
to
ca50dc1
Compare
hoh
force-pushed
the
hoh-metrics-limit-date-range
branch
2 times, most recently
from
8993ffe
to
872574c
Compare
|
Please, can you amend the last commits to just avoid to have 3 different commits with the same name? |
nesitor
reviewed
Jan 24, 2024
This causes a lot of data to be returned in the case of old nodes and is usually unnecessary. Solution: Default to limiting the query to the last 2 weeks of data, or to 2 weeks before the specified date of last data.
hoh
force-pushed
the
hoh-metrics-limit-date-range
branch
from
367b2a5
to
963850f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a lot of data to be returned in the case of old nodes and is usually unnecessary.
Solution: Default to limiting the query to the last 2 weeks of data, or to 2 weeks before the specified date of last data.
This also renames
start_date -> start_timestampandend_date -> end_timestampto prevent confusion since these fields are expected to be timestamps and note datetime or ISO 8601.Related to #528