Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow developers to use nix-shell to get started #554

Merged
merged 13 commits into from
Feb 23, 2024
Merged

Conversation

hoh
Copy link
Member

@hoh hoh commented Feb 14, 2024

Solution: Provide a shell.nix file so developers can just run nix-shell to start temporary PostgreSQL and Redis servers.

The exit signal of the shell is trap-ed in order to automatically stop the services on exit.

nix-shell-pyaleph.mp4

…bases

Solution: Provide a `shell.nix` file so developers can just run `nix-shell` to start temporary PostgreSQL and Redis servers.

The exit signal of the shell is `trap`-ed in order to automatically stop the services on exit.
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some documentation of this feature to the README.md please?

@hoh hoh marked this pull request as draft February 14, 2024 16:40
@hoh hoh marked this pull request as ready for review February 14, 2024 16:46
@hoh hoh marked this pull request as draft February 14, 2024 16:48
@hoh
Copy link
Member Author

hoh commented Feb 14, 2024

I added the Python environment as well:

pyaleph-nix-shell.mp4

@hoh hoh changed the title Fix: Developers needed to manually create a PostgreSQL and Redis databases Allow developers to use nix-shell to get started Feb 14, 2024
@hoh hoh marked this pull request as ready for review February 14, 2024 17:24
README.md Outdated Show resolved Hide resolved
Co-authored-by: Hugo Herter <git@hugoherter.com>
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit e7877d5 into main Feb 23, 2024
4 checks passed
@MHHukiewitz MHHukiewitz deleted the hoh-nix-shell branch February 23, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants