Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sortBy/sortOrder on Message/Post queries #555

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Fix sortBy/sortOrder on Message/Post queries #555

merged 2 commits into from
Feb 23, 2024

Conversation

philogicae
Copy link
Member

@philogicae philogicae commented Feb 19, 2024 •
edited
Loading

Found issues:

  • Linked to issue 95 on SDK -> Solved here: PR
  • No sorting when queries request it, even after changing SDK codebase:

Proposed solution:

  • Added missing aliases on BaseMessageQueryParams & PostQueryParams

@hoh

This was referenced Feb 19, 2024
Merged
Open
MHHukiewitz
MHHukiewitz previously approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philogicae
Copy link
Member Author

Fixed the tests, all good now normally

hoh
hoh reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@hoh hoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good overall 👍

tests/api/test_list_messages.py Show resolved Hide resolved
@MHHukiewitz MHHukiewitz merged commit 4fb1f8f into aleph-im:main Feb 23, 2024
2 checks passed
aliel added a commit that referenced this pull request Mar 4, 2024
@aliel
revert #555 test fix, restore sort_order and sort_by
c89b6ef
@aliel aliel mentioned this pull request Mar 4, 2024
Merged
aliel added a commit that referenced this pull request Mar 4, 2024
@aliel
revert #555 test fix, restore sort_order and sort_by
d2e771f
hoh pushed a commit that referenced this pull request Mar 4, 2024
@aliel @hoh
revert #555 test fix, restore sort_order and sort_by
78f17db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoh hoh hoh left review comments

@MHHukiewitz MHHukiewitz MHHukiewitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philogicae @hoh @MHHukiewitz