Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregate filter by keys #556

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix aggregate filter by keys #556

merged 1 commit into from
Feb 20, 2024

Conversation

aliel
Copy link
Member

@aliel aliel commented Feb 19, 2024

Fix regression introduced by (#473)

@aliel
Fix regression introduced by (#473)
ff3efb7 
* Fix aggregate filter by keys
@aliel aliel force-pushed the aliel-fix-agg-keys-regression branch from ef08b9d to ff3efb7 Compare February 19, 2024 16:20
@aliel aliel requested a review from hoh February 19, 2024 16:25
hoh
hoh approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@hoh hoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! Simple fix and the test that goes with it, perfect !

@hoh hoh merged commit 3a0165a into main Feb 20, 2024
2 checks passed
@Psycojoker Psycojoker deleted the aliel-fix-agg-keys-regression branch July 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoh hoh hoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliel @hoh